in array.c array_contains() doesn't work

[gianmaria]

/**
 * Returns the number of occurrences of the element within the specified array.
 *
 * @param[in] ar the array that is being searched
 * @param[in] element the element that is being searched for
 *
 * @return the number of occurrences of the element
 */
size_t array_contains(Array *ar, void *element)
{
    size_t o = 0;
    size_t i;
    for (i = 0; i < ar->size; i++) {
        if (element == ar->buffer[i])  <------------ this line
            o++;
    }
    return o;
}

in array.c you are comparing only the addresses not the actual data, you need a comparison function as argument to array_contains
@srdja

[srdja]

Technically it works, because comparing the pointer values was the original idea, but now that you mention it it may not be the most obvious. or the most useful thing to do. So yes, a comparator function should be included.

[pkill37]

Couldn't you just dereference the pointers and compare the values? What is the benefit of passing a comparator function? :)

[f2404]

@faviouz It's not allowed to dereference a void * pointer.

[pkill37]

Ah, of course! :)

[f2404]

Looks very similar to #18, right?

[gianmaria]

@f2404 yes indeed

[srdja]

I've added a contains variant that takes a comparison function. One should now be able to search for the actual values pointed to by the container elements.