CC_ITER_END vs CC_ERR_OUT_OF_RANGE

[f2404]

Different statuses are returned in the same situation - when iterator reaches end of array:

 * @return CC_OK if a next element pair is returned, or CC_ITER_END if the end of one
 * of the arrays has been reached.
 */
enum cc_stat array_zip_iter_next(ArrayZipIter *iter, void **out1, void **out2)

 * @return CC_OK if the element was successfully removed, or CC_ERR_OUT_OF_RANGE.
 */
enum cc_stat array_zip_iter_remove(ArrayZipIter *iter, void **out1, void **out2)

Which status should be used to be consistent? I'd suggest using CC_ITER_END whenever an iterator is involved.

[f2404]

@srdja ?

[srdja]

The problem was that the behaviors of array_*_iter_remove and deque_*_iter_remove functions were kind of inconsistent with their list and slist equivalents, in that you could call iter_remove repeatedly until you've exausted the array, and thus possibly running into an CC_ERR_OUT_OF_RANGE, which is not the case with list equivalents where you can only call iter_remove once after calling iter_next. Basically array_iter_remove was allowing you to 'jump ahead' of the iterator which is not something that should ever happen.

I've added a fix for this. It should be more sensible now :-)