Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speakable fails on Node.js v4.2.1 due to spawh() changes #13

Closed
francip opened this issue Oct 14, 2015 · 5 comments · Fixed by #16
Closed

Speakable fails on Node.js v4.2.1 due to spawh() changes #13

francip opened this issue Oct 14, 2015 · 5 comments · Fixed by #16

Comments

@francip
Copy link

francip commented Oct 14, 2015

Running speakable on Node.js v4.2.1 fails with [TypeError: options argument must be an object]. This happens when trying to spawn the sox process (node-speakable.js, line 75) due to the options argument passed being a string.

The quick fix for this is to change that line to

var rec = spawn(self.cmd, self.cmdArgs, {stdio:'pipe'});

I haven't tested this change on Node.js v0.12.x though.

@gcrev93
Copy link

gcrev93 commented Feb 8, 2016

I am having the same issue. Have you by any chance fixed it?

@joestrong
Copy link
Contributor

@gcrev93 Some people have fix this particular issue, for example https://github.com/ajay-gandhi/node-speakable

I still can't get this library to work however, possibly due to the last commit being 2 years ago

@Jamil
Copy link
Contributor

Jamil commented Feb 27, 2016

Seems to work once that change is made. Works on node/0.12.7 and node/5.7.0

@joestrong
Copy link
Contributor

Yeah the fix does stop the error
(I think I may have a separate issue)

@lluiscab
Copy link

It doesn't seem to work in nodejs 7.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants