Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] journals with negative journal-interval-index are created before time visible in caldendar before start date #28

Closed
danieltomasz opened this issue Mar 19, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@danieltomasz
Copy link

danieltomasz commented Mar 19, 2024

Great plugin, I am switching to it from periodic notes :)
I want to create a custom weekly journal with the data starting from today (or any other day) and I have active calendar journals.

The coustom journals are created for preceding time for all the times they are visible in the calendar, so I can have custom-journal -1, custom-journal -2, et cetera

image
I only want to have journals starting from 1

I am on Obsidian 1.5.11 and MacOS

@danieltomasz danieltomasz changed the title [BUG] journals with Negative journal-interval-index are creatwed before start date [BUG] journals with negative journal-interval-index are created before time visible in caldendar before start date Mar 19, 2024
@danieltomasz
Copy link
Author

danieltomasz commented Mar 19, 2024

Expected behaviour - the journal notes should not be created for period before start;
Also but this might be a FR - there should be a stop date that could be defined in settings for such calendar.

OK they existing notes are displayed in different colors, but having the notes from the start is confusing to me
image

@srg-kostyrko
Copy link
Owner

good point, I missed this somehow, will fix so that for interval journals with increasing index there won't be 0 and negative numbers. (I don't want to just limit by start date for cases then you start journaling not with index 1 you might still want go back till 1)

@srg-kostyrko srg-kostyrko added the bug Something isn't working label Mar 20, 2024
@danieltomasz
Copy link
Author

danieltomasz commented Mar 20, 2024

hi @srg-kostyrko thanks for looking into it!
I (someone) might want to have a journal with dates (no numbers) and still retain the desired behaviour I described;
For example the number is not important but I want this journal to be aout weekly meetings about a project that spans only specific time (like 3 or 6 months) and I want to quickly find a note from specific data, the order of meetings/notes is not important for me

I will create another feature request to ask about ending date, but returning to the initial issue, could it be solved via giving user a choice via additional toggle in the settings (like "strict enforce starting (and closing if you implent it) date(s)")? Or "Limit note creation by starting date");

This way you will also get consistent behaviour independently from naming convention, which might be more intuitive to user and cover more cases, some user might not be bothered by notes with numbering below zero :)

@srg-kostyrko
Copy link
Owner

yeh that's a good point
than I'll add a toggle to limit journal entries by start and dates

@srg-kostyrko srg-kostyrko added enhancement New feature or request and removed bug Something isn't working labels Mar 21, 2024
@srg-kostyrko
Copy link
Owner

released in 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants