Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCrystal Changes #10

Closed
pastimee opened this issue Mar 4, 2021 · 4 comments
Closed

AutoCrystal Changes #10

pastimee opened this issue Mar 4, 2021 · 4 comments

Comments

@pastimee
Copy link

pastimee commented Mar 4, 2021

  1. remove cancel crystal, it's a placebo and does nothing for your ca. (if you don't believe me, setup a counter on the SPacketDestroyEntities event and count broken crystals, cancel crystal does not affect that in any way)
  2. Implement an actual raytrace, the current one does not help with wall placements whatsoever and actually hurts wall placements on some servers
  3. Implement an actual rotations system, overriding the packet send on CPacketPlayer bypasses no servers.
  4. Make new CanPlaceCrystal methods as the current ones are pretty bad
  5. The entire ca is basically just gamesense, I would invest some time in rewriting it since gamesense's ca rn isn't great
@srgantmoomoo
Copy link
Owner

the only thing i directly used gamesense for were most of the utils, which do include things like canPlaceCrystals, and i plan on rewriting stuff like that. i tend to get a lot of complaints about the placement especially in chasing situations it seems, which does have a lot to do with stuff like canPlaceCrystal, and my utils in general, it's something im working on. Also, this is why i use cancelCrystal https://www.youtube.com/watch?v=rfhV-t2IkFc. obviously have to work on placing/breaking for proper multiplacing. thank u for the criticism, linus is cool person.

@pastimee
Copy link
Author

pastimee commented Mar 5, 2021

the multiplacing is because of the canPlaceCrystal.

that video doesn't prove anything, the ca is going fast cause you have 20 ms (refer to my test)

@srgantmoomoo
Copy link
Owner

i wasn't trying to prove anything with the video, i am aware of canPlaceCrystals involvement, "which does have a lot to do with stuff like canPlaceCrystal". i am simply showing why i currently use cancel crystal. i have not gotten around to completely fixing postmans ca, certain things have been changed and fixed but as of now that in particular has not been. thank u for ur critiquing, it does help, once i get around to rewriting the ca i may remove cancel crystal. i don't have a lot of time rn which rlly sucks when something like this is just starting to pick up, but im currently working on a lot of rewrites for this client, i almost just gave up on it with how much code isn't mine, but i realized the amount of support behind this project is pretty valuable and rare (for someone like me at least). thank u a lot for pointing out what u did, it will certainly be worked on when i have enough time, and i appreciate someone like you pointing out ways to fix it.

@pastimee
Copy link
Author

pastimee commented Mar 5, 2021

sounds amazing man, can't wait 👍

@pastimee pastimee closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants