Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux sagas unnecessary? #10

Closed
headwinds opened this issue Oct 22, 2017 · 1 comment
Closed

redux sagas unnecessary? #10

headwinds opened this issue Oct 22, 2017 · 1 comment

Comments

@headwinds
Copy link

headwinds commented Oct 22, 2017

I went through your awesome example and learned quite a lot.

I see that you actually decided not to use redux sagas though - did you do this because it's not necessary once you have Apollo setup?

This Apollo article seems to confirm that redux-sagas may not be needed but if we wanted to talk to a API that wasn't using GraphQL wouldn't one still need to use a thunk or a saga to make that call?

@srghma
Copy link
Owner

srghma commented Nov 3, 2017

@headwinds
sorry for late response, didn't receive email about your comments

I have slightly abandoned this project lately

Sagas ... I think something like this is necessary (how I'll make auth module without them?), but I want to use redux-logic (application structure I saw when learned ngrx, awesome article from creator)

Also, I want to try https://github.com/nozzle/react-static, because next.js stopped in development

Also seems like relay is better because it doesn't make me do low-level error-prone things

Also, containers structure will be like

\presentations
   \default.tsx
   \error.tsx
   \no-data.tsx
\feature.ts - joins presentations with recompose (branches), adds logic by wrapping in per-component redux store (withState) 
\apollo/relay/dunno.ts
\index.ts - wraps feature.ts in apollo and main redux store

@srghma srghma closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants