New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cycles should be displayed inside the associated cluster #101
Comments
@srid |
That's a good question: why should cycles be displayed as an error at all? They're quite natural |
@clojj There are two graphs here, conceptually:
The former includes "?cf" links (which can cyclically link to notes), while the later does not. If you can understand what a folgezettel connection (as distinct from an ordinary connection (i.e., cf)) means, then you can see how a folgezettel heterarchy cannot be cyclic. |
Example of folgezettel heterarchy from my public zettelkasten: https://www.srid.ca/z-index.html |
Ah, I finally understand the distinction... I think it would be helpful to link to the documentation in the error message about cycles if it's not already the case. Here is how I think we could handle it. We would first compute the DAG of strongly connected components. When displaying the tree, you just follow the graph as before from the roots of that DAG. Since there is already a system to not display subtrees twice, I don't think cycles would break anything. The only problem is if a root is itself part of a cycle (i.e. a root component has more than one node), but then I think it's fine to break the cycle arbitrarily. The user can always break the cycle manually if needed. |
@srid thx for clarification ! |
neuron doesn't look for cycles anymore. |
Cycles are currently shown globally. But they must appear within their associated cluster.
To do this:
mother
return the list of subgraphs (instead of list of lists of zids)The text was updated successfully, but these errors were encountered: