Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using buildHtml, sourceUrl is incorrect #78

Closed
srid opened this issue Jan 3, 2020 · 1 comment · Fixed by #79
Closed

When using buildHtml, sourceUrl is incorrect #78

srid opened this issue Jan 3, 2020 · 1 comment · Fixed by #79
Labels
bug Something isn't working
Projects
Development
Milestone
0.6

Comments

@srid
Copy link
Owner

srid commented Jan 3, 2020

To fix it, make readSource set a custom source URL.

More generally, perhaps sourceUrl should not be computed automatically especially as the target HTML path can be changed by the user.
@srid srid added the bug Something isn't working label Jan 3, 2020
@srid srid added this to the 0.6 milestone Jan 3, 2020
@srid srid assigned srid and unassigned srid Jan 3, 2020
@srid srid added this to To do in Development Jan 3, 2020
@srid
Copy link
Owner Author

srid commented Jan 3, 2020

Customize sourceUrl

@srid srid mentioned this issue Jan 4, 2020
Merged
@srid srid closed this as completed in #79 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Development
  
To do
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Have buildHtml set sourceUrl srid/rib
1 participant
@srid