-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --experimental_allow_proto3_optional support #14
Comments
I am stuck with missing proto3 optional support for gotag and protoc-gen-validate plugins :) |
@srikrsna why this is closed? plugin still can't set tags to optional fields |
Can you try to use protoc-gen-go-micro it supports setting tags |
@k1ng440 Thank you for flagging it is now fixed in the latest release. |
On the latest version 0.6.2 I'm still getting this error when using the |
@Mexican-Man The example in the project uses |
I actually tied with latest version. It works now optional string email = 10 [(tagger.tags) = "avro:\"email\" graphql:\"withNewTags,optional\"" ]; Using with Buf tooling |
You're right, it works fine. I tried the older releases, but none of them do what I'm experiencing... I'm going to look into my deps for anything outdated/weird (old version of protoc?). In the mean time: whoops! I'll close my pr, and I'll post back if I find anything. |
protoc v3.12.0 is going to add experimental support for the optional annotation to proto3 (see RC: https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0-rc1). We may need to update our generator(s) (protoc-gen-grpc-gateway, protoc-gen-swagger). Doc for adding this ability is here: https://github.com/protocolbuffers/protobuf/blob/v3.12.0-rc1/docs/implementing_proto3_presence.md.
The text was updated successfully, but these errors were encountered: