Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing cvx CheckInterfaceName() #1224

Merged
merged 2 commits into from Jan 27, 2023
Merged

fixing cvx CheckInterfaceName() #1224

merged 2 commits into from Jan 27, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jan 27, 2023 •
edited by hellt

fix #1222

@steiler
Copy link
Collaborator Author

steiler commented Jan 27, 2023

@hellt I suggest making CheckInterfaceName() in default_node a noop. Just logging that the CheckInterfaceName() is not implemented for that kind.
If this is a rule that applies for all the vr kinds, that lets introduce either an abstract vr kind or a general check function that all the vr types call.

@steiler steiler marked this pull request as ready for review January 27, 2023 08:39
@hellt
Copy link
Member

hellt commented Jan 27, 2023

thanks @steiler

@hellt hellt merged commit b93be31 into srl-labs:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to define a link with interfaces prefixed with swp
2 participants
@steiler @hellt