make DefaultNode Interface Name Check a noop #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreve
reviewed
Mar 2, 2023
nodes/default_node.go
Outdated
| @@ -175,15 +174,6 @@ func (d *DefaultNode) DeleteNetnsSymlink() error { | |||
| // Checks the name pattern that is common for VM-based nodes. Container-based nodes override this function to implement | |||
| // custom name checks. | |||
There was a problem hiding this comment.
You may want to change this comment as well as I think it could be misleading.
Btw. thanks for the link to the build in #1275.
|
@steiler what if we had just a function named "vmIntfCheck" that the VR kinds would use in the override function to all use the same ethX pattern? |
|
Yes, that is the other option. Further we could also consolidate the SaveConfig, which is also the same for all the vr instances. |
|
Hi @steiler |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quickfix for #1275 making InterfaceNameCheck on DefaultNode a NOOP