Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Creation supported by DependencyManager #1395

Merged
merged 11 commits into from May 24, 2023
Merged

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented May 17, 2023

We where busy waiting for the nodes statuses to change to "created", before creating links for a set of nodes.
With this we will rely on DependencyManager to block the go func until the depending nodes are created.

clab/clab.go Outdated Show resolved Hide resolved
clab/dependency_manager.go Outdated Show resolved Hide resolved
@hellt hellt marked this pull request as draft May 17, 2023 14:17
@hellt
Copy link
Member

hellt commented May 17, 2023

moved to draft since more work will be done in that PR

@steiler steiler force-pushed the linkCreationDependencyManager branch from 36a6936 to 9ba5c06 Compare May 22, 2023 09:36
@steiler steiler marked this pull request as ready for review May 22, 2023 10:32
@steiler steiler mentioned this pull request May 22, 2023
clab/clab.go Show resolved Hide resolved
clab/clab.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1395 (255e405) into main (02ecec3) will decrease coverage by 0.17%.
The diff coverage is 1.93%.

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   20.51%   20.35%   -0.17%     
==========================================
  Files          58       58              
  Lines        6428     6479      +51     
==========================================
  Hits         1319     1319              
- Misses       4986     5037      +51     
  Partials      123      123              
Impacted Files Coverage Δ
clab/config.go 47.31% <0.00%> (+0.19%) ⬆️
clab/dependency_manager/dependency_manager.go 24.85% <0.00%> (ø)
cmd/deploy.go 6.83% <0.00%> (-0.06%) ⬇️
types/types.go 0.00% <ø> (ø)
clab/clab.go 32.02% <5.35%> (+1.06%) ⬆️

@hellt hellt merged commit fd7e0b4 into main May 24, 2023
18 of 19 checks passed
@hellt hellt deleted the linkCreationDependencyManager branch May 24, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants