Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clab supports version 1.0 of OVS bridges. Need support to up to 1.5 #1538

Closed
pdumais opened this issue Aug 19, 2023 · 3 comments
Closed

clab supports version 1.0 of OVS bridges. Need support to up to 1.5 #1538

pdumais opened this issue Aug 19, 2023 · 3 comments
Assignees

Comments

@pdumais
Copy link
Contributor

pdumais commented Aug 19, 2023

it is impossible to set the OVS bridge to protocols=OpenFlow13 using ovs-vsctl before launching clab. We can set the protocol version after clab is launched. But this complicates automation scripts. It would be nice to get that fixed.

The solution is to change the parameters of the connection that the ovs library creates.
It should be as easy as doing client := ovs.New(goOvs.Sudo(), ovs.FlowFormat("OXM-OpenFlow15"), ovs.Protocols("OpenFlow15"))
Then the client would support all bridge versions up to 1.5

I have not tried this yet but I'm working on something to be able to test with 1.0 and all versions to 1.5. Once I can confirm the solution works, I can submit a PR.

@pdumais pdumais self-assigned this Aug 21, 2023
@pdumais
Copy link
Contributor Author

pdumais commented Aug 21, 2023

PR #1539

@hellt
Copy link
Member

hellt commented Aug 22, 2023

Looks like #1539 addresses just pre-condition of this feature request?

@steiler
Copy link
Collaborator

steiler commented Aug 29, 2023

Feedback from @pdumais: can closed

@steiler steiler closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants