Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ansible_httpapi_use_proxy: false to ansible inventory #1571

Merged
merged 2 commits into from Sep 1, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Sep 1, 2023

implementing #1569

@hellt
Copy link
Member

hellt commented Sep 1, 2023

@steiler yes, looks good, only the test needs to be adjusted

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1571 (cc6ab71) into main (ff1ae13) will increase coverage by 0.08%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   48.58%   48.67%   +0.08%     
==========================================
  Files         132      132              
  Lines       12689    12749      +60     
==========================================
+ Hits         6165     6205      +40     
- Misses       5822     5839      +17     
- Partials      702      705       +3     
Files Changed Coverage Δ
clab/inventory.go 87.50% <100.00%> (+0.93%) ⬆️

... and 6 files with indirect coverage changes

@hellt hellt merged commit c4b64dd into srl-labs:main Sep 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants