Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use podman exec in podman runtime #1653

Merged
merged 1 commit into from Oct 18, 2023
Merged

Conversation

bewing
Copy link
Contributor

@bewing bewing commented Oct 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1653 (6b09215) into main (ca9c72b) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
+ Coverage   50.83%   50.85%   +0.02%     
==========================================
  Files         135      135              
  Lines       13107    13107              
==========================================
+ Hits         6663     6666       +3     
+ Misses       5711     5708       -3     
  Partials      733      733              
Files Coverage Δ
utils/networkcli.go 72.34% <ø> (ø)

... and 2 files with indirect coverage changes

@bewing
Copy link
Contributor Author

bewing commented Oct 17, 2023

Before: endless loop on cEOS deploy:

# containerlab -r podman deploy --debug
...
DEBU[0000] clab-ztp-tor2 - Cli not ready (exec: no command) - waiting.
DEBU[0000] clab-ztp-tor1 - Cli not ready (exec: no command) - waiting.
DEBU[0000] clab-ztp-spine - Cli not ready (exec: no command) - waiting.
DEBU[0002] clab-ztp-tor1 - Cli not ready (exec: no command) - waiting.
DEBU[0002] clab-ztp-spine - Cli not ready (exec: no command) - waiting.
DEBU[0002] clab-ztp-tor2 - Cli not ready (exec: no command) - waiting.
DEBU[0004] clab-ztp-spine - Cli not ready (exec: no command) - waiting.
DEBU[0004] clab-ztp-tor1 - Cli not ready (exec: no command) - waiting.
DEBU[0004] clab-ztp-tor2 - Cli not ready (exec: no command) - waiting.
...

After:

# containerlab -r podman deploy --debug
DEBU[0004] clab-ztp-spine - Cli not ready (read /dev/ptmx: input/output error) - waiting.
DEBU[0004] clab-ztp-tor2 - Cli not ready (read /dev/ptmx: input/output error) - waiting.
DEBU[0004] clab-ztp-tor1 - Cli not ready (read /dev/ptmx: input/output error) - waiting.
...
DEBU[0013] clab-ztp-tor2 - Cli not ready (errPrivilegeError: failed to acquire target privilege level 'privilege-exec') - waiting.
DEBU[0014] clab-ztp-tor1 - Cli not ready (errPrivilegeError: failed to acquire target privilege level 'privilege-exec') - waiting.
DEBU[0014] clab-ztp-spine - Cli not ready (errPrivilegeError: failed to acquire target privilege level 'privilege-exec') - waiting.
DEBU[0021] clab-ztp-tor1 - Cli ready.
DEBU[0022] clab-ztp-tor2 - Cli ready.
DEBU[0022] clab-ztp-spine - Cli ready.
...

@hellt hellt merged commit 56c3d19 into srl-labs:main Oct 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants