Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate srl mgmt0 config with runtime mgmt bridge mtu #1658

Merged
merged 3 commits into from Oct 20, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Oct 19, 2023

Implementing #1655

Comment on lines +77 to +79
{{- if ne .MgmtIPMTU 0 }}
set / interface mgmt0 subinterface 0 ip-mtu {{ .MgmtIPMTU }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steiler check this
unfortunately we can't use link mtu lower than 1500
to make it work we need to use ip mtu.
This is what I was alluding to in the original issue.

take a look at this change in 257917b
I don't quite like it, but maybe for the time being it will do

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1658 (257917b) into main (670d658) will increase coverage by 0.02%.
The diff coverage is 69.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   50.96%   50.99%   +0.02%     
==========================================
  Files         136      136              
  Lines       13188    13202      +14     
==========================================
+ Hits         6721     6732      +11     
- Misses       5726     5727       +1     
- Partials      741      743       +2     
Files Coverage Δ
types/types.go 60.00% <ø> (ø)
runtime/podman/util.go 77.77% <0.00%> (ø)
nodes/srl/srl.go 57.19% <37.50%> (-0.01%) ⬇️
runtime/docker/docker.go 64.59% <73.46%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

@steiler
Copy link
Collaborator Author

steiler commented Oct 20, 2023

lgtm

@hellt hellt merged commit 283aec1 into srl-labs:main Oct 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants