Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not keep more than 3 DNS servers and init default DNS struct #1671

Merged
merged 4 commits into from Oct 24, 2023
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Oct 24, 2023

fix #1670

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1671 (70b803d) into main (cd3c3cf) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
- Coverage   51.05%   51.04%   -0.01%     
==========================================
  Files         138      138              
  Lines       13339    13350      +11     
==========================================
+ Hits         6810     6815       +5     
- Misses       5776     5780       +4     
- Partials      753      755       +2     
Files Coverage Δ
types/topology.go 68.01% <100.00%> (+0.49%) ⬆️
utils/resolve.go 94.44% <100.00%> (+0.89%) ⬆️

... and 2 files with indirect coverage changes

@hellt hellt merged commit 93e2e92 into main Oct 24, 2023
21 of 22 checks passed
@hellt hellt deleted the dns-fixes branch October 24, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS entries for SR Linux should be limited to the first 3 entries
1 participant