Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing stacktrace on wrong brief link format #1691

Merged
merged 5 commits into from Nov 7, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 1, 2023

fix #1690

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1691 (4a1d7ec) into main (735e561) will increase coverage by 0.33%.
Report is 12 commits behind head on main.
The diff coverage is 53.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
+ Coverage   51.32%   51.65%   +0.33%     
==========================================
  Files         138      141       +3     
  Lines       13357    13716     +359     
==========================================
+ Hits         6855     7085     +230     
- Misses       5742     5851     +109     
- Partials      760      780      +20     
Files Coverage Δ
links/link.go 62.74% <100.00%> (+1.20%) ⬆️
links/link_host.go 66.66% <25.00%> (-2.96%) ⬇️
links/link_macvlan.go 50.96% <25.00%> (-1.32%) ⬇️
links/link_mgmt-net.go 64.13% <25.00%> (-2.54%) ⬇️
links/link_veth.go 83.73% <25.00%> (-2.22%) ⬇️

... and 10 files with indirect coverage changes

@hellt hellt merged commit ed0ceb8 into srl-labs:main Nov 7, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When endpoint definition in brief format missing a : it causes panic
2 participants