Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroy: fix folder as topology ref #1747

Merged
merged 5 commits into from Nov 29, 2023
Merged

destroy: fix folder as topology ref #1747

merged 5 commits into from Nov 29, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 27, 2023

fixing #1745

@steiler steiler marked this pull request as ready for review November 28, 2023 08:53
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #1747 (0f50831) into main (ab128e4) will decrease coverage by 0.08%.
The diff coverage is 84.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   51.97%   51.89%   -0.08%     
==========================================
  Files         144      144              
  Lines       13961    13964       +3     
==========================================
- Hits         7256     7247       -9     
- Misses       5893     5902       +9     
- Partials      812      815       +3     
Files Coverage Δ
clab/config.go 66.58% <ø> (-0.26%) ⬇️
types/topo_paths.go 69.67% <100.00%> (+0.25%) ⬆️
clab/clab.go 76.67% <90.32%> (+0.08%) ⬆️
cmd/destroy.go 66.50% <25.00%> (-1.00%) ⬇️

... and 2 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented Nov 29, 2023

Thanks @steiler!

@hellt hellt merged commit e1ae5e0 into srl-labs:main Nov 29, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants