Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec: throw error on no containers matching filter #1786

Merged
merged 1 commit into from Dec 15, 2023
Merged

Exec: throw error on no containers matching filter #1786

merged 1 commit into from Dec 15, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Dec 15, 2023

Fixing #1748

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #1786 (5d87f05) into main (c777995) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
+ Coverage   51.15%   51.16%   +0.01%     
==========================================
  Files         147      147              
  Lines       14228    14230       +2     
==========================================
+ Hits         7278     7281       +3     
- Misses       6131     6132       +1     
+ Partials      819      817       -2     
Files Coverage Δ
cmd/exec.go 73.11% <100.00%> (+0.59%) ⬆️
runtime/ignite/ignite.go 0.31% <0.00%> (ø)

... and 3 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented Dec 15, 2023

thanks mate

@hellt hellt merged commit d27945a into main Dec 15, 2023
22 checks passed
@hellt hellt deleted the fixing1748 branch December 15, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants