Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added acl rules for srl 24.3+ #1968

Merged
merged 3 commits into from Apr 4, 2024
Merged

Added acl rules for srl 24.3+ #1968

merged 3 commits into from Apr 4, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Apr 2, 2024

  • add a simple http test with curl

@hellt hellt marked this pull request as ready for review April 3, 2024 09:11
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.61%. Comparing base (c0f4a74) to head (fecbbf8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
- Coverage   53.82%   53.61%   -0.22%     
==========================================
  Files         159      160       +1     
  Lines       11492    11536      +44     
==========================================
- Hits         6186     6185       -1     
- Misses       4445     4488      +43     
- Partials      861      863       +2     
Files Coverage Δ
nodes/srl/srl.go 58.51% <ø> (ø)
nodes/srl/version.go 75.00% <100.00%> (+1.92%) ⬆️

... and 3 files with indirect coverage changes

@hellt hellt merged commit 85bda39 into main Apr 4, 2024
62 of 63 checks passed
@hellt hellt deleted the srl-http-telnet branch April 4, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant