Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect: fixes all, by name and topology file #1984

Merged
merged 8 commits into from Apr 11, 2024
Merged

Inspect: fixes all, by name and topology file #1984

merged 8 commits into from Apr 11, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Apr 11, 2024

This should fix #1982 and fix #1958

@steiler
Copy link
Collaborator Author

steiler commented Apr 11, 2024

This is still an intermediate solution. We should not need to instantiate a clab instance to query nodes by a random label...
But for now is does the trick.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.63%. Comparing base (0a94452) to head (e673bdc).
Report is 2 commits behind head on main.

❗ Current head e673bdc differs from pull request most recent head 523834d. Consider uploading reports for the commit 523834d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   53.64%   53.63%   -0.01%     
==========================================
  Files         160      160              
  Lines       11538    11536       -2     
==========================================
- Hits         6189     6187       -2     
  Misses       4485     4485              
  Partials      864      864              
Files Coverage Δ
clab/clab.go 70.22% <100.00%> (ø)
clab/hostsfile.go 61.03% <100.00%> (ø)
cmd/inspect.go 83.07% <100.00%> (-0.26%) ⬇️

@hellt hellt merged commit d455379 into main Apr 11, 2024
58 checks passed
@hellt hellt deleted the fixinspectnames branch April 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clab inspect -t <path> issues with v 0.53.0 "clab inspect <LAB Name>" from any directory
2 participants