Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use client certificate chain #11

Closed
MuniekMg opened this issue Sep 21, 2022 · 2 comments
Closed

Unable to use client certificate chain #11

MuniekMg opened this issue Sep 21, 2022 · 2 comments

Comments

@MuniekMg
Copy link
Contributor

MuniekMg commented Sep 21, 2022

Hi, great project, thank you for your work! :)

From version 4.6 we are unable to pass client certificate chain, because client certificate is passed by SecIdentity and SecIndetity is unable to hold certificate chain. I have created PR to your project solving this problem: #10

I asked Apple engineer about my solution and he confirmed that this is correct solution:
https://developer.apple.com/forums/thread/715174

All tests passed.

@sroebert
Copy link
Owner

Thank you for the improvements. I have merged, but changed the enum back into a separate new property for clientIdentityCertificates in order to make it backwards compatible. The enum will go on the list of breaking changes for version 3.0 to improve the API.

@MuniekMg
Copy link
Contributor Author

Great 👍 Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants