Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag mistakenly called md5 when representing sha1 #26

Open
itraviv opened this issue Oct 29, 2019 · 3 comments
Open

tag mistakenly called md5 when representing sha1 #26

itraviv opened this issue Oct 29, 2019 · 3 comments

Comments

@itraviv
Copy link

itraviv commented Oct 29, 2019

tag number 269 is declared as sha-1 in the rpm source:
original rpm source (line 62)

in the headers section it is identified as "md5":
headers (line 13)

RPMTAG_SIG_BASE = HEADER_SIGBASE (=256)
256+13=269 which is RPMTAG_SHA1HEADER = RPMTAG_SIG_BASE+13, /* s */ (line 62 as linked above)

@pdxjohnny
Copy link
Collaborator

Hi @itraviv, I'm a bit confused as to what the desired fix is here.

@itraviv
Copy link
Author

itraviv commented Apr 2, 2020

i think a rename to 'sha1' will be enough as it'd be just as the spec.
i can make a PR if you want

@pdxjohnny
Copy link
Collaborator

Thanks that would be great! But just in case anyone is importing / using the existing variable, can we leave the old declaration too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants