New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jedi to v0.13.1 #277
Conversation
I kind of like this approach until Sublime upgrades its Python interpreter but I suggest to do it in a way that is easy to maintain. Let's make a fork of Jedi and apply there the patch for Python 3.3 compatibility and let's point the make file there. As long we Sublime has this old Python we maintain our fork and when it upgrades then we delete it and repoint the Makefile. What about that? @srusskih |
That's not a bad idea @edelvalle - the only alternative I guess is produce a Regardless, it's working well this branch for me - sure there is some solution worth doing. 👍 |
Thanks! Great job!
Could you please create a patch-file and add include it PR? |
Well spotted @srusskih - I'll grep the new version of Jedi and find any other instances of Along with those other concerns + a patch. I guess you're thinking we then exec. said patch from |
@magnetikonline Thanks a lot! 👍 |
No dramas @srusskih - a bit flat out with other items at the moment, but it's on my todo list! Using SL Jedi in anger the last week with this patched branch, it's been working really well. |
Just rebased |
I hope complete it during next couple weeks, have started https://github.com/srusskih/SublimeJEDI/tree/jedi-0.13.x have to update |
@magnetikonline |
I'm testing, seems to be ok... Tomorrow will use it the whole day.... let's see |
@edelvalle thank you |
Nice work @srusskih - I'll switch branches now for today..... will report back! |
Just noted 0.13.2 released of Jedi. |
Also @srusskih the new branch is running very solid! 👍 |
I can confirm too...
working all good!
|
I've just merged in https://github.com/davidhalter/jedi/releases/tag/v0.13.2 to my branch to give that a test - also including your changes too from your https://github.com/srusskih/SublimeJEDI/tree/jedi-0.13.x branch. What |
Been successfully running |
@magnetikonline I think we can merge your PR, If you do not mind. |
@srusskih let's do it. All running solid here. Edit: Just cleaned up commit messages 👇 |
Argh! Left out your Edit: ....and, that's better - build now passing! |
Change to update Jedi package to v0.13.1.
Note: this does cause an issue, where Jedi has now dropped support for Python 3.3 - so had to patch
access.py
here and here.Makefile
won't work as is without patching of thejedi
package.Otherwise, all good.