Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization does not work if the certificate contains more than 10 (sub)domains #475

Closed
ghost opened this issue Jan 16, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 16, 2020

Line:

getssl/getssl

Line 1187 in 9895a21

echo "$full" | grep "^..${5}\",$section" | awk '{print $2}' | tr -d '"'

Maybe also at line:

getssl/getssl

Line 1191 in 9895a21

echo "$full" | grep "^..${2}\",$section" | grep "$5" | awk '{print $2}' | tr -d '"'

If $section contains the value 1, the line 1187 will find the link for 1, 10, 11, 12, 13 and anything starting with 1.

The line must be like this:

echo "$full" | grep "^..${5}\",$section\]" | awk '{print $2}' | tr -d '"

\] after $section

Version: getssl 2.15

@ghost ghost changed the title Authorization does not work if the certificate contains more than 10 domains Authorization does not work if the certificate contains more than 10 (sub)domains Jan 16, 2020
@pmarsden
Copy link

Changing Line 1187 only fixed it for me.

Changing 1191 as well broke the token extraction.

@timkimber
Copy link
Member

Thanks for finding and suggesting a fix for this. I've made the change in the branch fix-more-than-10-domains - if you can test this and it works I'll include the next release.

@pmarsden
Copy link

As I mentioned above, the change in line 1187 (only) fixed the issue for me.

Do not change line 1191, that broke token extraction.

@timkimber
Copy link
Member

I've merged the fix into master and it will be part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants