-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-01 files left behind with ftpes, ftps, ... #693
Comments
@tlhackque thanks for pointing the issue out, I'd not noticed this when looking through the code but will fix. |
Might want to have tests verify that Same for DNS Would have caught this issue. |
I thought I was going to have to use FTP a while ago - but it turned out otherwise. However, below is (untested in Also, with respect to left-over DNS records: see
|
Code reading bug.
While debugging something else, I noticed that
fulfill_challenges
only knows how to remove tokens with (regular) FTP and SSH.But
copy_file_to_location
also knows how to place tokens with SFTP, DAVS, FTPES, and SFTP.fulfill_challenges
will try to remove such tokens as local files (hopefully and usually failing), thus leaving them behind in.well-known/acme-challenge
.fulfill_challenges
needs to learn how to remove files using these protocols - or at least not try to delete them as local files.See
curl
-Q and -X for an approach. Something likecurl ... server/locn/token -Q "-DELE token" >/dev/null
should work for the FTP versions. (Yes, there's a '-' before DELE. And it will transfer the (small) file before deleting it.) SFTP would be similar, but-Q "rm token"
. And DAVS would be-X DELETE
.I haven't coded and tested these - too busy working on something else, and not setup for the protocols. Treat them as clues.
The text was updated successfully, but these errors were encountered: