Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarballs don't contain test code #111

Closed
yurivict opened this issue Nov 6, 2021 · 4 comments
Closed

tarballs don't contain test code #111

yurivict opened this issue Nov 6, 2021 · 4 comments
Assignees

Comments

@yurivict
Copy link

yurivict commented Nov 6, 2021

The tarball doesn't contain the code for testing:

CMake Error at examples/CMakeLists.txt:61 (add_executable):
  Cannot find source file:

    S97_libsmoldyn/testcode/testcode.cpp

This makes tarballs unusable for packaging systems which have an option to run tests after build, like FreeBSD ports.

@ssandrews
Copy link
Owner

I'm confused about why this code isn't included in your tarball. The code is clearly on the github site, and is in the listed directory. What commands are you running to cause this error to appear?

@yurivict
Copy link
Author

yurivict commented Nov 8, 2021

It downloads tarballs from https://www.smoldyn.org/, not from GitHub.

How do you make tarballs?

@ssandrews
Copy link
Owner

Sorry for the slow reply. I was initially thinking that you were downloading tarballs from github somehow. Anyhow, I just fixed the release script so that it will include the testcode.cpp file in future releases. Would it be helpful for you if I went ahead and created a new release now that includes this fix? If not, then I'll just wait until the next release. Clearly, the file is on github, so you can download it from there, too.

@yurivict
Copy link
Author

Changing in the next release is fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants