Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModestTree namespace #18

Closed
svermeulen opened this issue Sep 23, 2014 · 3 comments
Closed

Remove ModestTree namespace #18

svermeulen opened this issue Sep 23, 2014 · 3 comments

Comments

@svermeulen
Copy link

Given that Zenject is open source and not proprietary to ModestTree it should really be in its own namespace.

@unknowndevice
Copy link

What do you propose for the new namespaces? The following is being used:

  • ModestTree
  • ModestTree.Zenject
  • ModestTree.Tests
  • ModestTree.Tests.Zenject
  • ModestTree.Asteroids

It could be changed to?

  • Zenject
  • Zenject.Main
  • Zenject.Tests
  • Zenject.Tests.Main
  • Asteroids

Or something else! Let me know and I'll push the change.

@svermeulen
Copy link
Author

Yep those are what I was thinking too. I went ahead and made the change.

It's going to cause some compile errors for people so I've been kind of dreading the change but better sooner than later I guess.

@unknowndevice
Copy link

Thanks!

JamesKim2998 pushed a commit to devsisters/Zenject that referenced this issue Mar 11, 2020
…ge-during-subscription

SignalBus: Changes to error message giving more context - when trying to subscribe or fire an undeclared signal.
weiping-playnext pushed a commit to Wonderplanet/Zenject that referenced this issue Mar 11, 2021
…ge-during-subscription

SignalBus: Changes to error message giving more context - when trying to subscribe or fire an undeclared signal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants