Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rules] Find and replace 'echo' statements with their function name #137

Closed
sscargal opened this issue May 5, 2022 · 0 comments · Fixed by #139
Closed

[Rules] Find and replace 'echo' statements with their function name #137

sscargal opened this issue May 5, 2022 · 0 comments · Fixed by #139
Labels
enhancement New feature or request

Comments

@sscargal
Copy link
Owner

sscargal commented May 5, 2022

Some of the rules use legacy echo statements with the message type, eg:

  if [ "${ERR_STATE}" = true ] ; then
    echo "${STR_FAIL} ${FUNCNAME[0]} : One or more PMem modules reported an unexpected LockState status. See previous errors."

These echo statements should be replaced with their equivalent function, ie:

  if [ "${ERR_STATE}" = true ] ; then
    fail_msg "One or more PMem modules reported an unexpected LockState status. See previous errors."

See common/common for a list of implemented message type functions

@sscargal sscargal added the enhancement New feature or request label May 5, 2022
@sscargal sscargal mentioned this issue May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant