Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WrapperComponent not supported by Jenny? #532

Closed
jwvanderbeck opened this issue Dec 26, 2017 · 6 comments
Closed

WrapperComponent not supported by Jenny? #532

jwvanderbeck opened this issue Dec 26, 2017 · 6 comments

Comments

@jwvanderbeck
Copy link

In previous projects, with the old code generator, I was using this amazing add-on https://github.com/sschmid/Entitas-CSharp/pull/88/files

Support was added as part of Entitas core in this commit:
f17bd30

However this no longer appears to work, as components built using WrapperComponent are not getting proper code generated for them. The generated code is the same as that of Flag Components rather that of Data components as they should.

This worked for me before, so I am making the assumption here that it somehow got lost in the split up of the code base maybe and Jenny just needs to be fixed to ignore the Abstract class like before?

@sschmid
Copy link
Owner

sschmid commented Dec 29, 2017

I see, roslyn is lacking support as it is not recognizing the public field of the inherited class.

@sschmid
Copy link
Owner

sschmid commented Dec 29, 2017

I just added support for subclassing components in roslyn which will enable the WrapperComponent. I see you've read my concerns about the WrapperComponent and that you are aware and fine with that :)

@jwvanderbeck
Copy link
Author

Yeah I abhor the use of var when at all possible and much prefer explicit types, so I am ok with the implicit conversion which simplifies the overall API.

Certainly good to have the option for those who want it and I loved using it in the old generator :)

@jwvanderbeck
Copy link
Author

Any idea when this update will hit the Asset Store or is there some other way to obtain the fix?

@sschmid
Copy link
Owner

sschmid commented Jan 9, 2018

Sorry, got sick. Will release this week

@sschmid
Copy link
Owner

sschmid commented Jan 10, 2018

Hi, fixed in Entitas 0.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants