Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method name of IStartSystem could lead to conflicts when used on a MonoBehaviour #20

Closed
chrischu opened this issue Aug 11, 2015 · 1 comment

Comments

@chrischu
Copy link
Contributor

In my application it makes sense to manifest some systems in form of a MonoBehaviour on a GameObject (for example when I want to configure them through the editor, like giving them a reference to another GameObject that is relevant to them).

However since the method in IStartSystem is called Start, Unity thinks this method is actually the MonoBehaviour Start method that is used by Unity to initialize stuff.

Maybe it would be better to rename IStartSystem.Start to IInitializeSystem.Initialize.

Beside from fixing the problem described I also think it would nicely illustrate the distinguish between the Unity Start/Update concepts and the Entitas Initialize/Execute concepts.

@sschmid
Copy link
Owner

sschmid commented Aug 16, 2015

Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants