Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component value change in Inspector doesn't use entity componentPool #73

Closed
ifshuaishuai opened this issue Feb 29, 2016 · 3 comments
Closed
Labels

Comments

@ifshuaishuai
Copy link

I found out when change a component's value when game running in Unity Inspector, the event OnEntityRemoved and OnEntityUpdated doesn't work. The first one get call with Component's value already changed. The last one get call with previousComponent equals to newComponent. I wonder if it is an issue.

@sschmid
Copy link
Owner

sschmid commented Feb 29, 2016

Yes, I see... VisualDebugging is not yet updated to use the new entity componentPool. By updating components with the inspector, the actual values of the component get modified. The same changed component is then used when calling entity.ReplaceComponent(). That's why you currently see that previous and new components are the same instance.
I'll work on updating VisualDebugging to use the componentPool too and to ensure expected behaviour.
Good find! Thanks for letting me know

@sschmid sschmid changed the title Component value change in Inspector doesn't function well Component value change in Inspector doesn't use entity componentPool Feb 29, 2016
@sschmid
Copy link
Owner

sschmid commented Mar 6, 2016

This has been fixed in Entitas 0.29.0

@sschmid sschmid closed this as completed Mar 6, 2016
@ifshuaishuai
Copy link
Author

Nice work, I'll try that out. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants