Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change animation button from "play" to "pause" when animation is running, and add animation speed button. #411

Open
ameraner opened this issue May 7, 2024 · 1 comment
Labels
component: ui enhancement New feature or request

Comments

@ameraner
Copy link
Collaborator

ameraner commented May 7, 2024

Currently, when an animation is running, no change in the animation buttons can be seen. This can be confusing in certain situations, e.g. when the animation speed is very low or too fast (screen update not keeping up), and the user doesn't know if the animation is running or not.

This could be improved by switching to a classic pause button || when the animation is running, or keeping the "play" button pressed until it is clicked on again.

In addition, the animation speed slider can only be changed when right-clicking the "play" button, which is not intuitive/clear to a new user. A new button or always-visible slider should be added.

Ported from EUM Gitlab issue 173.

@ameraner ameraner added enhancement New feature or request component: ui EUM-WIP This issue is (scheduled to) being worked on by EUM labels May 7, 2024
@ameraner
Copy link
Collaborator Author

Relevant piece of code:

sift/uwsift/__main__.py

Lines 292 to 295 in ac7d431

def toggle_animation(self, action: QtWidgets.QAction = None, *args):
"""Toggle animation on/off."""
new_state = self.scene_manager.animation_controller.toggle_animation()
self.ui.animPlayPause.setChecked(new_state)

@ameraner ameraner removed the EUM-WIP This issue is (scheduled to) being worked on by EUM label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant