Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multiple sources of information #167

Open
vretro opened this issue Jul 14, 2017 · 1 comment
Open

Merge multiple sources of information #167

vretro opened this issue Jul 14, 2017 · 1 comment

Comments

@vretro
Copy link

vretro commented Jul 14, 2017

Thank you for your continued efforts with scraper

I have a feature request I'd like to run past you.

I've found many sources of data available in scraper provide inaccurate player counts. Is it possible to have an option to always append a higher player count if a higher value is returned?

This way inaccurate values will more likely be replaced with accurate values. Also values which are already correct, are less likely to be replaced with smaller inaccurate values.

Thanks

@sselph
Copy link
Owner

sselph commented Jul 15, 2017

This is an interesting idea. It could easily be extended to other properties. Players is an odd property. When I first saw it, I made it an integer and then had it soon fail when values were 1-2, 4+, and other odd values. If I assumed 1 was somewhat of a default and anything else was probably correct it could work. This would be slower since I would have to make 1 query per data source then merge vs today where I query each in series and stop once one returns a real value.

I won't make any promises but will think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants