Go 1.10.2 build failure for 0.12.3

[ilovezfs]

==> Cloning https://github.com/ssh-vault/ssh-vault.git
Updating /Users/joe/Library/Caches/Homebrew/ssh-vault--git
git config remote.origin.url https://github.com/ssh-vault/ssh-vault.git
git config remote.origin.fetch +refs/tags/0.12.3:refs/tags/0.12.3
==> Checking out tag 0.12.3
git checkout -f 0.12.3 --
HEAD is now at 33b59a3... prefer the HOME environmental variable
git reset --hard 0.12.3
HEAD is now at 33b59a3 prefer the HOME environmental variable
==> dep ensure -vendor-only
==> go build -ldflags -s -w -X main.version=0.12.3 -o /usr/local/Cellar/ssh-vault/0.12.3/bin/ssh-vault cmd/ssh-vault/main.go
# github.com/ssh-vault/ssh-vault/vendor/github.com/ssh-vault/go-keychain
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:29: cannot use nil as type _Ctype_CFDataRef in return argument
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:36: cannot convert nil to type _Ctype_CFDataRef
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:37: cannot use nil as type _Ctype_CFDataRef in return argument
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:62: cannot convert nil to type _Ctype_CFDictionaryRef
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:63: cannot use nil as type _Ctype_CFDictionaryRef in return argument
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:74: cannot convert &keys[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:74: cannot convert &values[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:87: cannot use nil as type _Ctype_CFStringRef in return argument
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:90: cannot use nil as type _Ctype_CFStringRef in return argument
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:141: cannot convert &a[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/ssh-vault/go-keychain/corefoundation.go:141: too many errors
/usr/local/Homebrew/Library/Homebrew/debrew.rb:11:in `raise'
BuildError: Failed executing: go build -ldflags -s\ -w\ -X\ main.version=0.12.3 -o /usr/local/Cellar/ssh-vault/0.12.3/bin/ssh-vault cmd/ssh-vault/main.go

(doesn't affect Go 1.9.x)

[nbari]

@ilovezfs Hi, many thanks, I just updated it should work now: Homebrew/homebrew-core#28768

[ilovezfs]

Thanks for the fix @nbari!

[nbari]

@ilovezfs more than welcome :-) by the way how to use brew bump-formula-pr to create the PR without the need to authenticate via HTTP via command line? I have hub configured but when it tries to create the PR ask for http github credentials and I need to do a git push -f to my fork and from there manually do the PR.

[ilovezfs]

bump-formula-pr no longer uses hub as of Homebrew/brew#3870. It should use your HOMEBREW_GITHUB_API_TOKEN if you set that environment variable to a GitHub token with the relevant authorizations.

[nbari]

@ilovezfs I used indeed export HOMEBREW_GITHUB_API_TOKEN=xxx but didn't work, it is indeed the same token I used with hub

[ilovezfs]

Make sure the token has write permissions. If it's still giving you trouble, open a ticket at https://github.com/Homebrew/brew and fill out the template as there may be a bug.

[nbari]

@ilovezfs Ok, many thanks 👍