-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support temporary schemas in get_schema()
#107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
RasmusSkytte
force-pushed
the
feature/get_temporary_schemas
branch
from
February 9, 2024 13:58
4e798a3
to
410fb5b
Compare
RasmusSkytte
force-pushed
the
feature/get_temporary_schemas
branch
from
February 12, 2024 08:31
db48e00
to
b2152a1
Compare
RasmusSkytte
force-pushed
the
feature/get_temporary_schemas
branch
3 times, most recently
from
February 12, 2024 11:02
19f813c
to
4ac1fb5
Compare
RasmusSkytte
force-pushed
the
feature/get_temporary_schemas
branch
from
February 12, 2024 11:25
836146a
to
3a9b192
Compare
RasmusSkytte
requested review from
a team,
kaare-gr and
LasseEngboChr
and removed request for
a team
February 12, 2024 11:34
6 tasks
LasseEngboChr
approved these changes
Feb 20, 2024
LasseEngboChr
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR adds the
temporary
argument toget_schema()
,get_catalog()
to allow it to get the temporary schema/catalog for the connection.In addition,
get_schema()
can now infer the schema from tbl_dbi objects (by usingid()
internally).Tests are also added and improved
The CI workflows for Microsoft SQL Server has also been updated over on
AEF-DDF
.Before, the both the permanent and temporary databases were called "tempdb" which masked a few issues in the identification functions. The new workflows uses "master" and "tempdb" respectively, so we also fix some previously undetected issues.
The documentation of the S3 methods
get_schema()
andget_catalog()
was adjusted to try to figure out the best way of documenting the functions. Discussion available on #69.Approach
The
temporary
parameter was added to someget_schema()
methods.id()
was used to infer schema from tbl_dbiBugfixes made for
table_exists()
andget_tables()
, specifically for MSSQLBetter error message added for id.tbl_dbi in case table has been deleted.
Known issues
Tests for PostgreSQL are showing as failing.
This is caused by an update to the Workflows so that previously undetected errors are now being explicitly shown.
The source of the error is being fixed in #98
Checklist
NEWS.md