Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id.data.frame #108

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add id.data.frame #108

merged 3 commits into from
Feb 21, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Feb 13, 2024

Intent

Fixes #74

Approach

  • A id.data.frame method is added.

  • This method is used to simplify id.tbl_dbi

Known issues

This PR also contains the code being merged in

Once merged, this PR will be rebased and opened.

Tests for PostgreSQL are showing as failing.
This is caused by an update to the Workflows so that previously undetected errors are now being explicitly shown.
The source of the error is being fixed in #98

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Feb 13, 2024
@RasmusSkytte RasmusSkytte marked this pull request as draft February 13, 2024 13:15
@RasmusSkytte RasmusSkytte added this to the v0.4 milestone Feb 13, 2024
@RasmusSkytte RasmusSkytte mentioned this pull request Feb 14, 2024
6 tasks
@RasmusSkytte RasmusSkytte marked this pull request as ready for review February 20, 2024 13:58
Copy link
Contributor

@LasseEngboChr LasseEngboChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add tests of 'id.data.frame'

@RasmusSkytte RasmusSkytte merged commit ba0d43a into main Feb 21, 2024
25 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/74-id-data-frame branch February 21, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add id.data.frame method
2 participants