Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable initialising Logger with no arguments #24

Merged
merged 10 commits into from
Sep 4, 2023

Conversation

marcusmunch
Copy link
Collaborator

@marcusmunch marcusmunch commented Sep 1, 2023

Logger$generate_filename() has been changed to an active binding Logger$log_filename

With these changes, the Logger will not require db_tablestring and ts to be set until Logger$log_filename is called, and only when attempting to write an actual file (closes #17).

Instead of taking arguments log_table_id and/or log_path (or neither), update_snapshot now may take an already initialized Logger object with the logger argument, allowing for better control of console output (closes #16).

@marcusmunch marcusmunch changed the title Enable initialising Logger with no arguments at all Enable initialising Logger with no arguments Sep 1, 2023
@marcusmunch marcusmunch marked this pull request as ready for review September 1, 2023 14:14
R/update_snapshot.R Outdated Show resolved Hide resolved
@marcusmunch marcusmunch merged commit 0eecc8e into ssi-dk:main Sep 4, 2023
@marcusmunch marcusmunch deleted the logger-output-options branch September 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default arguments to Logger Improve control of console printing when using update_snapshot()
2 participants