Enable initialising Logger with no arguments #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger$generate_filename()
has been changed to an active bindingLogger$log_filename
With these changes, the
Logger
will not requiredb_tablestring
andts
to be set untilLogger$log_filename
is called, and only when attempting to write an actual file (closes #17).Instead of taking arguments
log_table_id
and/orlog_path
(or neither),update_snapshot
now may take an already initializedLogger
object with thelogger
argument, allowing for better control of console output (closes #16).