-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logger$finalize() #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This closes #64.
Approach
I have added a
Logger$finalize()
function (see also R6#finalizer in Advanced R).Currently, it does nothing unless
log_path
isNULL
andlog_tbl
is notNULL
.The finalizer generates a query which sets all
log_file
in the DB toNULL
if they were previously equal toself$log_filename
(i.e. exactly what I described in #64).1For usability/readability, I added a bit of logic to
table_exists
to compensate for the shortcomings ofDBI::dbExistsTable
.Known issues
More feature than bud: Since the DB connection is stored within a
tbl_dbi
object,table_exists
does not care about theconn
argument ifdb_table_id
inherits fromtbl_dbi
.Checklist
NEWS.md
Footnotes
This is done with DBI::dbExecute as
dplyr::rows_update
(naturally) cannot match a log_file that is not NULL with one that is 🙃 . ↩