Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check testthat availabililty before return #90

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: Check testthat availabililty before return #90

merged 2 commits into from
Jan 19, 2024

Conversation

marcusmunch
Copy link
Collaborator

Intent

This PR fixes an issue where dplyr *_joins fail if testthat is not installed.

Approach

In join_warn() and join_warn_experimental(), check if testthat is installed before calling testthat::is_testing().

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@marcusmunch marcusmunch added bug Something isn't working good first issue Good for newcomers labels Jan 19, 2024
RasmusSkytte
RasmusSkytte reviewed Jan 19, 2024
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@RasmusSkytte
Chore: Update NEWS.md
b2bf3d6 
Co-authored-by: Rasmus Skytte Randløv <rasmusskytteeriksen@gmail.com>
@marcusmunch marcusmunch merged commit 20f4e28 into main Jan 19, 2024
6 checks passed
@marcusmunch marcusmunch deleted the testthat-conditional branch January 19, 2024 13:07
marcusmunch pushed a commit that referenced this pull request Jan 19, 2024
fix: Check testthat availabililty before return (#90)
17dc692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusSkytte RasmusSkytte RasmusSkytte approved these changes

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcusmunch @RasmusSkytte