Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR makes a few, relatively minor changes to the package. Primarily focusing on clean up.
See the Approach section for the changes introduced
Approach
The
%notin%
operator was removed.This was left over from our original migration but is not used in the package and does not really fit the scope of the package.
The order of arguments to
create_logs_if_missing()
was swapped to better conform the other package functions which hasconn
as the first argument (unless it takes.data
argument, then it takes precedence).create_logs_if_missing()
now hasconn
as first argument.The use of
%>%
in examples was changed to|>
to be aligned with the rest of the package.This also led to minor reformatting of the examples in question.
The linting of the assertion helpers were fixed so the
nolint:
suppression is no longer neededThe return values of
schema_exists()
is made explicit instead of implicit.return()
was changed toreturn(NULL)
in some placesThe triggering of
db_join
warnings were simplified to not rely on "testthat::is_testing" but instead useinteractive()
to determine if the warnings should be produced.Known issues
This PR also contains the code being merged inMove functions to separate files #95Once merged, this PR will be rebased and opened.Checklist
NEWS.md