Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cleanup #96

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Package cleanup #96

merged 6 commits into from
Feb 2, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Feb 1, 2024

Intent

This PR makes a few, relatively minor changes to the package. Primarily focusing on clean up.
See the Approach section for the changes introduced

Approach

  • The %notin% operator was removed.
    This was left over from our original migration but is not used in the package and does not really fit the scope of the package.

  • The order of arguments to create_logs_if_missing() was swapped to better conform the other package functions which has conn as the first argument (unless it takes .data argument, then it takes precedence).
    create_logs_if_missing() now has conn as first argument.

  • The use of %>% in examples was changed to |> to be aligned with the rest of the package.
    This also led to minor reformatting of the examples in question.

  • The linting of the assertion helpers were fixed so the nolint: suppression is no longer needed

  • The return values of schema_exists() is made explicit instead of implicit.

  • return() was changed to return(NULL) in some places

  • The triggering of db_join warnings were simplified to not rely on "testthat::is_testing" but instead use interactive() to determine if the warnings should be produced.

Known issues

This PR also contains the code being merged in

Once merged, this PR will be rebased and opened.

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Feb 1, 2024
@RasmusSkytte RasmusSkytte marked this pull request as draft February 1, 2024 09:16
@RasmusSkytte RasmusSkytte marked this pull request as ready for review February 1, 2024 14:21
@RasmusSkytte RasmusSkytte requested review from a team, kaare-gr and LasseEngboChr and removed request for a team February 1, 2024 14:21
@RasmusSkytte RasmusSkytte merged commit e9274f6 into main Feb 2, 2024
24 checks passed
@RasmusSkytte RasmusSkytte deleted the chore/adjustment branch February 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants