Add catalog information #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusSkytte
force-pushed
the
feature/catalog_information
branch
from
898beed
to
34a494d
Compare
RasmusSkytte
requested review from
a team,
kaare-gr and
LasseEngboChr
and removed request for
a team
LasseEngboChr
requested changes
Feb 2, 2024
Co-authored-by: Lasse Engbo Christiansen <147731649+LasseEngboChr@users.noreply.github.com>
LasseEngboChr
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR expands our support for catalogs and does some improvements for
get_schema().This should bring us closer to fixing issue #94
Approach
Tests were added for
get_schema()When a schema cannot be determined,
get_schema()returnsNULLinstead ofNAThis allows smoother incorporation with
DBI::Id.A new
get_catalog()method is added.In most cases, catalog will be
NULL, but for SQL Server, the database context is resolved.id()is expanded to account for catalog in more cases:id.character()now takes implied catalogid.Id()now attempts to determine catalog for SQL server connectionsKnown issues
This PR also contains the code being merged inMove functions to separate files #95Once merged, this PR will be rebased and opened.Checklist
NEWS.md