Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table identification #121

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Improve table identification #121

merged 8 commits into from
Mar 13, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jan 29, 2024

Intent

This PR serves as a stop-gap for table identification issues being fixed for SCDB (ssi-dk/SCDB#93).
To make releasing these issues for SCDB as smoothly as possibly, we here make some small stop-gap changes so the updates don't break diseasystore

Incidentally, this PR also fixes issues with SQLite w. schemas.

Approach

Identification of tables is improved by using SCDB::id() explicitly some places and converting to corresponding character representations manually.

For drop_diseasystore, identification of where the diseasystore tables are located is now resolved by SCDB::id(). This is then used to create the relevant regex'es to match tables to delete.

Known issues

This PR also contains the code being merged in

Tests and checks for SCDB v0.4 is still failing.
Remember that these were added to track our progress towards SCDB v0.4 compatibility and not required to succeed for every PR.

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 93.78%. Comparing base (4bd988b) to head (16d77f3).

Files Patch % Lines
R/drop_diseasystore.R 78.57% 6 Missing ⚠️
R/DiseasystoreBase.R 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   95.00%   93.78%   -1.22%     
==========================================
  Files          14       14              
  Lines         980      997      +17     
==========================================
+ Hits          931      935       +4     
- Misses         49       62      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte self-assigned this Jan 29, 2024
@RasmusSkytte RasmusSkytte added this to the v0.2 milestone Jan 31, 2024
@RasmusSkytte RasmusSkytte added enhancement New feature or request bug Something isn't working labels Jan 31, 2024
@RasmusSkytte RasmusSkytte reopened this Mar 11, 2024
@RasmusSkytte RasmusSkytte force-pushed the fix/id_ambiguity branch 2 times, most recently from ea18080 to 182744b Compare March 11, 2024 12:10
@RasmusSkytte RasmusSkytte marked this pull request as ready for review March 11, 2024 14:04
@RasmusSkytte RasmusSkytte merged commit e351ac7 into main Mar 13, 2024
20 of 40 checks passed
@RasmusSkytte RasmusSkytte deleted the fix/id_ambiguity branch March 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants