-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve table identification #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 95.00% 93.78% -1.22%
==========================================
Files 14 14
Lines 980 997 +17
==========================================
+ Hits 931 935 +4
- Misses 49 62 +13 ☔ View full report in Codecov by Sentry. |
4 tasks
RasmusSkytte
added
enhancement
New feature or request
bug
Something isn't working
labels
Jan 31, 2024
7 tasks
RasmusSkytte
force-pushed
the
fix/id_ambiguity
branch
from
March 11, 2024 11:50
c39024a
to
8e42ffd
Compare
RasmusSkytte
force-pushed
the
fix/id_ambiguity
branch
2 times, most recently
from
March 11, 2024 12:10
ea18080
to
182744b
Compare
RasmusSkytte
force-pushed
the
fix/id_ambiguity
branch
from
March 11, 2024 12:29
182744b
to
959ae0a
Compare
5 tasks
LasseEngboChr
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR serves as a stop-gap for table identification issues being fixed for SCDB (ssi-dk/SCDB#93).
To make releasing these issues for SCDB as smoothly as possibly, we here make some small stop-gap changes so the updates don't break
diseasystore
Incidentally, this PR also fixes issues with SQLite w. schemas.
Approach
Identification of tables is improved by using
SCDB::id()
explicitly some places and converting to corresponding character representations manually.For
drop_diseasystore
, identification of where the diseasystore tables are located is now resolved bySCDB::id()
. This is then used to create the relevant regex'es to match tables to delete.Known issues
This PR also contains the code being merged inAdd tests on SQL Server back ends #111Once merged, this PR will be rebased and opened.Tests and checks for SCDB v0.4 is still failing.
Remember that these were added to track our progress towards SCDB v0.4 compatibility and not required to succeed for every PR.
Checklist
NEWS.md