Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to diseasyoption #122

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jan 31, 2024

Intent

This small PR adds a default value to diseasyoption via the .default argument.
(inspired by purrr::pluck())

Approach

N/A

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Jan 31, 2024
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Jan 31, 2024
@RasmusSkytte RasmusSkytte added this to the v0.2 milestone Jan 31, 2024
@RasmusSkytte RasmusSkytte reopened this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (7ccc836) to head (0c01463).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   96.29%   96.39%   +0.10%     
==========================================
  Files          13       13              
  Lines         702      722      +20     
==========================================
+ Hits          676      696      +20     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte requested review from a team, kaare-gr and LasseEngboChr and removed request for a team January 31, 2024 13:37
R/0_R6_utils.R Outdated Show resolved Hide resolved
@RasmusSkytte RasmusSkytte removed the request for review from kaare-gr March 5, 2024 09:08
@RasmusSkytte RasmusSkytte merged commit 262f079 into main Mar 5, 2024
25 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/diseasyoption_default branch March 5, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants