-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a testing suite for diseasystores #123
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 94.52% 95.00% +0.47%
==========================================
Files 13 14 +1
Lines 749 980 +231
==========================================
+ Hits 708 931 +223
- Misses 41 49 +8 ☔ View full report in Codecov by Sentry. |
94cfa92
to
6a0150f
Compare
e1231b7
to
643d9a8
Compare
4ac55cc
to
1268177
Compare
1268177
to
7182f3a
Compare
7182f3a
to
acf728e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider avoiding ..1 and ..2 in walk2
Intent
Fixes #90
Approach
The tests for
DiseasystoreGoogleCovid19
was generalised and moved to the new functiontest_diseasystore()
.This function takes any generator (R6 class specification) for a diseasystore and runs a standard set of tests on the diseasystore.
This allows us to quickly test new diseasystores as we create them.
Known issues
This PR also contains the code being merged inAdd default value to diseasyoption #122Once merged, this PR will be rebased and opened.Checklist
NEWS.md