Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a testing suite for diseasystores #123

Merged
merged 17 commits into from
Mar 12, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jan 31, 2024

Intent

Fixes #90

Approach

The tests for DiseasystoreGoogleCovid19 was generalised and moved to the new function test_diseasystore().

This function takes any generator (R6 class specification) for a diseasystore and runs a standard set of tests on the diseasystore.

This allows us to quickly test new diseasystores as we create them.

Known issues

This PR also contains the code being merged in

Once merged, this PR will be rebased and opened.

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Jan 31, 2024
@RasmusSkytte RasmusSkytte marked this pull request as draft January 31, 2024 14:18
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 97.04641% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.00%. Comparing base (8e42ffd) to head (4775eb8).

Files Patch % Lines
R/test_diseasystore.R 97.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   94.52%   95.00%   +0.47%     
==========================================
  Files          13       14       +1     
  Lines         749      980     +231     
==========================================
+ Hits          708      931     +223     
- Misses         41       49       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte force-pushed the feature/standard_diseasystore_tests branch from 94cfa92 to 6a0150f Compare January 31, 2024 15:15
@RasmusSkytte RasmusSkytte force-pushed the feature/standard_diseasystore_tests branch 2 times, most recently from e1231b7 to 643d9a8 Compare February 14, 2024 11:07
@RasmusSkytte RasmusSkytte marked this pull request as ready for review February 14, 2024 19:50
@RasmusSkytte RasmusSkytte requested review from a team, kaare-gr and LasseEngboChr and removed request for a team February 14, 2024 19:50
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Feb 14, 2024
@RasmusSkytte RasmusSkytte marked this pull request as draft February 14, 2024 19:51
@RasmusSkytte RasmusSkytte force-pushed the feature/standard_diseasystore_tests branch from 4ac55cc to 1268177 Compare March 5, 2024 09:14
@RasmusSkytte RasmusSkytte added this to the v0.2 milestone Mar 5, 2024
@RasmusSkytte RasmusSkytte force-pushed the feature/standard_diseasystore_tests branch from 1268177 to 7182f3a Compare March 5, 2024 10:15
@RasmusSkytte RasmusSkytte marked this pull request as ready for review March 5, 2024 10:43
@RasmusSkytte RasmusSkytte force-pushed the feature/standard_diseasystore_tests branch from 7182f3a to acf728e Compare March 5, 2024 13:06
Copy link

@LasseEngboChr LasseEngboChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider avoiding ..1 and ..2 in walk2

@RasmusSkytte RasmusSkytte merged commit 4bd988b into main Mar 12, 2024
26 of 41 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/standard_diseasystore_tests branch March 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Standardise diseasystore testing
3 participants