-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diseasystore for ECDC respitory viruses data #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusSkytte
force-pushed
the
feature/diseasystoreEcdcRespitoryViruses
branch
from
March 13, 2024 08:47
c3c5b57
to
fafa089
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 93.78% 92.97% -0.81%
==========================================
Files 14 16 +2
Lines 997 1054 +57
==========================================
+ Hits 935 980 +45
- Misses 62 74 +12 ☔ View full report in Codecov by Sentry. |
RasmusSkytte
force-pushed
the
feature/diseasystoreEcdcRespitoryViruses
branch
5 times, most recently
from
March 15, 2024 07:45
d30ac38
to
c4eb842
Compare
RasmusSkytte
force-pushed
the
feature/diseasystoreEcdcRespitoryViruses
branch
from
March 15, 2024 07:51
c4eb842
to
5a8037b
Compare
SofiaOtero
reviewed
Mar 15, 2024
Co-authored-by: SofiaOtero <80672070+SofiaOtero@users.noreply.github.com>
SofiaOtero
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR introduces a diseasystore for the ECDC Respiratory Viruses Weekly Repository1.
Approach
source_conn_github()
To facilitate this diseaystore, a new helper function
source_conn_github()
which joins the family ofsource_conn_path()
.This function helps retrieve named files from GitHub repository.
If the given
source_conn
argument points to a folder with a git repo, the repo will be updated and the requested file path will be returned. Instead, if the argument is a (API) link to a GitHub repository, the GitHub API is utilised to retrieve the file path.In either case, we do some fuzzy matching to retrieve the newest file that is older or simultaneous with the requested date
(encoded in the file name being requested).
Say the only available files are "file_2022-01-01.csv" and "file_2022-06-01.csv" and we request the file "file_2022-05-01.csv", the file path to "file_2022-01-01.csv" is returned.
DiseasystoreEcdcRespitoryViruses
A new
diseasystore
was added with the following features:iliari_rates
infection_type
(ILI or ARI)age_group
Known issues
This uses code from a bunch of open PRs.These need to be merged before this will be rebased and openend.Improve table identification #121Add default value to diseasyoption #122Add a testing suite for diseasystores #123Checklist
NEWS.md
Footnotes
Note: new tongue-twister: "Respiratory Repository" ↩