Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DuckDB support #127

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Add DuckDB support #127

merged 7 commits into from
Mar 19, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Mar 5, 2024

Intent

This PR adds support for DuckDB

Approach

  • helper-setup.R was updated with the version from SCDB

  • DBI::dbDisconnect() now gets the shutdown = TRUE argument required by DuckDB

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Mar 5, 2024
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Mar 5, 2024
@RasmusSkytte RasmusSkytte marked this pull request as draft March 5, 2024 13:10
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (77ad8b1) to head (a7cdc72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          16       16           
  Lines        1109     1109           
=======================================
  Hits         1030     1030           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte force-pushed the feature/duckdb_support branch 2 times, most recently from 0ce0322 to 156a5e8 Compare March 19, 2024 09:06
@RasmusSkytte RasmusSkytte force-pushed the feature/duckdb_support branch 5 times, most recently from e3c12ae to c8d07e1 Compare March 19, 2024 10:09
@RasmusSkytte RasmusSkytte marked this pull request as ready for review March 19, 2024 10:38
@RasmusSkytte RasmusSkytte merged commit 934861b into main Mar 19, 2024
35 of 43 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/duckdb_support branch March 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants