Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response_time_setting_count in OUTPUT_RESPONSE_TIME_DESCRIPTION and MODULATION_FREQUENCY_DESCRIPTION #4

Closed
Letrab opened this issue Nov 20, 2020 · 3 comments

Comments

@Letrab
Copy link

Letrab commented Nov 20, 2020

Hi,

In the json description of OUTPUT_RESPONSE_TIME_DESCRIPTION and MODULATION_FREQUENCY_DESCRIPTION there is a GET parameter: response_time_setting_count

Is this a (copy/paste) error, as ANSI E1.37-1 – 2012 (R2017) does not mention an additional GET parameter, aside from the requested setting's number?

@peternewman
Copy link
Contributor

Again I'd agree:
http://rdm.openlighting.org/pid/display?manufacturer=0&pid=838

And:
http://rdm.openlighting.org/pid/display?manufacturer=0&pid=840

Looks like a typo from OUTPUT_RESPONSE_TIME and MODULATION_FREQUENCY.

@Letrab
Copy link
Author

Letrab commented Jan 5, 2021

@ssilverman: What is your thought on this?

@ssilverman
Copy link
Owner

You're right. Sorry to have missed the first notification; thanks for the ping. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants