Added GitHub Actions support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Looks good to me, thanks! There are a few features that I think necessary for an official CI integration. I'll add details to README after merging this PR. Once they are fixed, I'll consider releasing the action on the Actions Marketplace :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added GitHub Actions support for Rudra so this should make is easier to users to just run in their workflow.
One thing to note is that I created a second
Dockerfilewhich just pulls the latest version from GitHub Packages. This is because GitHub Actions will build the container versus pulling an image. Also it helped setting the Entrypoint for the image.The second thing is that I have left the inputs but they are not used. I wanted to add support for the Action to error out if Rudra found anything but that can be added to inputs as a flag or enabled by default in Actions.
It would also be great to see the Action on the Actions Marketplace in the near future.